[tor-bugs] #1836 [BridgeDB]: bridgedb captcha needs review

[Tor Bug Tracker & Wiki]

#1836: bridgedb captcha needs review
----------------------+-----------------------------------------------------
 Reporter:  aagbsn    |       Owner:  nickm                    
     Type:  task      |      Status:  needs_review             
 Priority:  normal    |   Milestone:  BridgeDB Upgrades Phase 1
Component:  BridgeDB  |     Version:                           
 Keywords:            |      Parent:                           
----------------------+-----------------------------------------------------

Comment(by aagbsn):

 Replying to [comment:4 nickm]:
 > It looks like this will now probably conflict with the i18n code?
 >
 > Also, Main.py was tracked already, in lib/bridgedb/Main.py.  Why add a
 new copy in ./ ?

 Oops. Fixed.
 >
 > Did you really mean to add values for RECAPTCHA_PUB_KEY and
 RECAPTCHA_PRIV_KEY in the source code?
 This was a result of a poor design. The values now live in bridgedb.conf,
 and the default testing configuration does not enable recaptcha support.
 >
 > I don't see a configuration option to turn recaptcha support on and off;
 there should probably be one.  Also, the RECAPTCHA_PUB/PRIV_KEY values
 probably belong there too, not in the source code: editing source files in
 order to configure a program is very 1990. ;)

 Very true. I added configuration options RECAPTCHA_ENABLED,
 RECAPTCHA_PRIV_KEY, RECAPTCHA_PUB_KEY to bridgedb.conf

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/1836#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online